There are different views on this. It seems certain that McKinley himself did not wish for war, but by the time the Spanish government did give show willingness to negotiate there was a huge popular demand among Americans for military action. He won the next election anyway, so probably there really was a wish among Americans to do this, whatever the rights and wrongs of it.